chore: drop dependency management in the CB #24061
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamzaremmal
force-pushed
the
drop-deps-cb
branch
from
51ab4d1 to
6ac0d6c
Compare
hamzaremmal
force-pushed
the
drop-deps-cb
branch
from
6ac0d6c to
f047303
Compare
hamzaremmal
force-pushed
the
drop-deps-cb
branch
from
527c8de to
68e78a7
Compare
| @Test def playJson = projects.playJson.run() | ||
| @Test def pprint = projects.pprint.run() | ||
| @Test def protoquill = projects.protoquill.run() | ||
| //@Test def protoquill = projects.protoquill.run() |
There was a problem hiding this comment.
Any particular reason to exclude? Is it failing to build?
There was a problem hiding this comment.
I've just seen a commit message which disabled it - let's add a comment in the source file instead so we'd be clear on why it was temporarily excluded
There was a problem hiding this comment.
Yes, it fails when we drop the dependencies. I'm not sure I want to wait for another 2+ hours for the CI for a comment I will be removing in my next PR (#23963) anyways.
WojciechMazur
approved these changes
Sep 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes were agreed on during the Core Meeting on September 24th, 2025.
[skip test]
[skip test_windows_fast]
[skip test_sbt]